-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api, shared-data): Move lid command implementation #17259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me, yeah. This is a lot of code that's now in both move labware and move lid, can we factor some of it into something common?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: Refactoring based on discussion regarding client and PD needs for load lid stack -> move labware -> move lid -> move labware command execution stackup.
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17299 |
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17299 |
A PR has been opened to address analyses snapshot changes. Please review the changes here: #17299 |
…snapshots (#17299) This PR was requested on the PRhttps://github.com//pull/17259 Update snapshot tests to reflect TC lid compatible parents
Overview
Covers EXEC-1005
Introduce
move_lid()
command to PAPI. Allows the movement of lids from stacks and source labware to destination labwares, stacks, or trash location. When a lid stack is emptied, it is moved to the new "systemLocation" location.Test Plan and Hands on Testing
Changelog
Introduces new move_lid() PAPI commands, alongside new state update commands to allow for lid updating and lid stack invalidation.
Review requests
Does the approach to returning Labware or None for move lid make sense when we're dealing with creating a new lid stack by moving a lid? The thought process here is:
Risk assessment
Low, new behavior and it gated behind API 2.23. Also impossible to use on earlier API versions anyways given the lack of Lid labware IDs on parent labwares, lack of lid stacks, and lack of the optional lid field on labwares.