feat(api): add execution of dispense steps for liquid class based transfer #17138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanni-t
commented
Dec 18, 2024
Comment on lines
87
to
99
| def update( | ||
| self, | ||
| liquid: Optional[float] = None, | ||
| air_gap: Optional[float] = None, | ||
| ready_to_aspirate: Optional[bool] = None, | ||
| ) -> None: | ||
| """Update the tip state contents with given values.""" | ||
| if liquid is not None: | ||
| self.last_liquid_and_air_gap_in_tip.liquid = liquid | ||
| if air_gap is not None: | ||
| self.last_liquid_and_air_gap_in_tip.air_gap = air_gap | ||
| if ready_to_aspirate is not None: | ||
| self.ready_to_aspirate = ready_to_aspirate |
sanni-t
commented
Dec 18, 2024
| `TransferComponentsExecutor`s should be ready_to_aspirate == True. | ||
| """ | ||
|
|
||
| ready_to_aspirate: bool = True |
There was a problem hiding this comment.
Consider making this an enum that keeps track of where the plunger is
sanni-t
changed the base branch from
AUTH-866-add-transfer-flow-builder
to
edge
sanni-t
force-pushed
the
AUTH-866-add-transfer-flow-builder-2
branch
from
c3cc384 to
9b2de59
Compare
sanni-t
changed the base branch from
edge
to
AUTH-866-add-transfer-flow-builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses AUTH-866
Overview
Part 2 of the three-part series of implementing transfer function.
This PR adds
InstrumentCore.dispense_liquid_class()which utilizes theTransferComponentsExecutorto execute the dispense steps in specific order.dispense_liquid_class()will then be utilized by theInstrumentCore.transfer_liquid()method to perform dispense during each transfer step. This method can also be accessed in the protocol by using private API accessors for testing purposes.Changes to
TransferComponentsExecutor:retract_after_dispensing()to execute post-dispense retraction stepsTest Plan and Hands on Testing
Review requests
TransferComponentsExecutor. Those will be addressed in the final PR. But let me know if there are any critical changes that should be made here.Risk assessment
Low. Makes no changes to the existing code.