Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(hardware): Add some logging around what I think is causing some can errors #17117

Merged
merged 3 commits into from
Jan 10, 2025
Merged

chore(hardware): Add some logging around what I think is causing some can errors #17117

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5024b7b
Add some logging around what I think is causing some can errors
ryanthecoder Dec 16, 2024
57766cb
logic flub
ryanthecoder Dec 20, 2024
bcd524d
condense logging
ryanthecoder Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions hardware/opentrons_hardware/drivers/can_bus/can_messenger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ async def send_and_verify_recieved(self) -> ErrorCode:
log.error(
f"Message did not receive ack for message index {self._message.payload.message_index}"
)
log.error(f"Missing node {self._expected_nodes}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we condense this and the previous message

return ErrorCode.timeout
finally:
self._can_messenger.remove_listener(self)
Expand Down Expand Up @@ -284,6 +285,7 @@ async def _ensure_send(
expected_nodes = list(self._known_nodes)
else:
expected_nodes = [node_id]
log.warning(f"Setting expected nodes to {expected_nodes}")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is going to flood the logs no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If everything is being done right this should never be in the logs, if we start seeing it, that mean's we are not setting up the can messages correctly and we need to hook up the "expected nodes" argument to this method.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we delete the one on line 282 then


listener = AcknowledgeListener(
can_messenger=self,
Expand Down
4 changes: 4 additions & 0 deletions hardware/opentrons_hardware/hardware_control/move_group_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,10 @@ def _remove_move_group(
f"Received completion for {node_id} group {group_id} seq {seq_id}"
f", which {'is' if in_group else 'isn''t'} in group"
)
if not self._moves[group_id] and len(self._moves[group_id]) == 0:
ryanthecoder marked this conversation as resolved.
Show resolved Hide resolved
log.error(
f"Python bug proven if check {bool(not self._moves[group_id])} len check {len(self._moves[group_id]) == 0}"
)
if not self._moves[group_id]:
log.debug(f"Move group {group_id+self._start_at_index} has completed.")
self._event.set()
Expand Down