Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flex-stacker): standardize the gcode responses to use key and value pairs. #498

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

vegano1
Copy link
Contributor

@vegano1 vegano1 commented Dec 19, 2024

Overview

While working on the flex stacker hardware controller, I noticed that some gcode responses have different formatting, some have key value responses, and others don't. So to make parsing consistent let's standardize the gcode responses to return key:value pairs which are easier to parse.

Changelog

  • Change the gcode message responses to key:value pairs where needed

Testing

  • Make sure that all the Gcodes still work and respond accordingly

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vegano1 vegano1 merged commit cf6cb33 into edge Dec 19, 2024
6 of 7 checks passed
@vegano1 vegano1 deleted the flex-stacker-standardize-gcode-response branch December 19, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants