-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(thermocycler): make sure the lid ease off the latch before attempting to open #471
feat(thermocycler): make sure the lid ease off the latch before attempting to open #471
Conversation
8f2935c
to
bc233d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, this looks good to me! THank you so much for dealing with this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM Gonna miss CLOSING_CLOSE_HINGE and OPENING_OPEN_HINGE
Overview
During ABR testing, we found that sometimes the thermocycler lid could get stuck on the latch while opening.
Hardware advised that we close the lid further, to allow the probes on the lid to ease off the latch plate, before releasing the latch. This should ensure that the latch and probes are not locked up by friction during lid opening.
Changelog
- first release the solenoid
- drive the lid closed 1 degree
- open the lid the first 10 degrees until the optical switch should be disengaged
- check that the optical switch was successfully disengaged
- open the lid the rest of the way