Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(thermocycler): make sure the lid ease off the latch before attempting to open #471

Merged

Conversation

ahiuchingau
Copy link
Contributor

@ahiuchingau ahiuchingau commented Oct 21, 2024

Overview

During ABR testing, we found that sometimes the thermocycler lid could get stuck on the latch while opening.

Hardware advised that we close the lid further, to allow the probes on the lid to ease off the latch plate, before releasing the latch. This should ensure that the latch and probes are not locked up by friction during lid opening.

Changelog

  • when opening the lid from the closed position:
    - first release the solenoid
    - drive the lid closed 1 degree
    - open the lid the first 10 degrees until the optical switch should be disengaged
    - check that the optical switch was successfully disengaged
    - open the lid the rest of the way
  • after opening the lid all the way, check that the 'lid open' limit switch is triggered and throw an error if it isn't
  • after backing off the 'lid open' switch, check that it is no longer engaged
  • after closing the lid, check that the 'lid closed' limit switch is triggered and throw an error if it isn't
  • after overdriving while closing the lid, check that the 'lid closed' switch is still triggered
  • no longer engage/disengage the solenoid during close lid to ensure the prongs have a chance to hook onto the latch

@caila-marashaj caila-marashaj force-pushed the RABR-637-thermocycler-latch-issues-with-disposable-lid branch from 8f2935c to bc233d3 Compare October 22, 2024 19:34
@ahiuchingau ahiuchingau marked this pull request as ready for review October 24, 2024 15:35
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, this looks good to me! THank you so much for dealing with this

Copy link
Contributor

@vegano1 vegano1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Copy link
Contributor

@ryanthecoder ryanthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Gonna miss CLOSING_CLOSE_HINGE and OPENING_OPEN_HINGE

@ahiuchingau ahiuchingau merged commit 49beb3b into edge Oct 25, 2024
6 of 7 checks passed
@ahiuchingau ahiuchingau deleted the RABR-637-thermocycler-latch-issues-with-disposable-lid branch October 25, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants