improvements to listing GH teams/members #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefaniebutland
approved these changes
Jun 11, 2024
seankross
approved these changes
Jun 13, 2024
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the first version of
list_team_members()it only returned the first 30 members. This is because there is a 30 record limit in the GH API, beyond which you need to paginate. Setting.limit = Infenables automatic pagination to get all records. This seems safe enough here as we're not ever going to get too many members for it to be a problem.This PR also makes specifying org and team names in
list_team_members()case insensitive, which will make it less prone to error unnecessarily. The API is not case sensitive.Finally, this PR adds the ability to get pending invitations via the new
membersargument inlist_team_members()(e.g.,list_team_members(team = "longtermaccess2i2c", org = "nasa-openscapes", members = "invitations").