feat(TopDown): add TopDown PMU Events #4122
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinceforYy
changed the title
sinceforYy
force-pushed
the
add-topdown
branch
from
857989a to
5d2533d
Compare
sinceforYy
requested review from
Tang-Haojin,
sumailyyc,
linjuanZ and
eastonman
sinceforYy
force-pushed
the
add-topdown
branch
from
5d2533d to
a861a9c
Compare
sinceforYy
requested review from
Ivyfeather,
cz4e,
good-circle,
happy-lx and
bosscharlie
as code owners
linjuanZ
approved these changes
Jan 6, 2025
Ivyfeather
approved these changes
Jan 6, 2025
|
remember to merge the changes in submodules into their masters first a PR in XiangShan must have all its submodules checked-out to their masters (otherwise CI would fail) |
Tang-Haojin
approved these changes
Jan 6, 2025
|
I don't understand. This PR does not distinguish frontend latency from bandwidth. Frontend latency is a counter that increases by 1 every time the decode bandwidth is not full. This does not make sense to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hardware synthesizable three-level categorized TopDown performance counters.
Level-1: Retiring, Frontend Bound, Bad Speculation, Backend Bound.
Level-2: Fetch Latency Bound, Fetch Bandwidth Bound, Branch Missprediction, machine clears, Core Bound, Memory Bound.
Leval-3: L1 Bound, L2 Bound, L3 Bound, Mem Bound, Store Bound.