refactor(commit): complete rewrite of commit mechanism #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yan-Muzi
force-pushed
the
dev-compress-enhance
branch
from
b0feec7 to
0cd5ff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely refactors the commit mechanism from frontend to backend, addressing the commit problem once and for all. Additionally, these changes are expected to save noticeable area for frontend.
The backend now guarantees that every FTQ entry is committed on time, rather than committing only a subset of instructions. To accomplish this, each ROB entry can now compress a maximum of two FTQ entries. As a result, the
commitStateQueueis no longer needed in the FTQ.During the refactoring process, some historical bugs were identified and fixed.
Attention: Modifications in the FTQ may lead to a noticeable drop in BP accuracy. Performance data should be checked before merging into master.