Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:requirements #21

Merged
merged 1 commit into from
Oct 1, 2024
+2 −2
Merged

fix:requirements #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions requirements/requirements.txt
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
ovos-plugin-manager~=0.0.18
ovos-plugin-manager>=0.0.18,<1.0.0
fastapi~=0.95
uvicorn~=0.22
gradio~=3.28
ovos-utils~=0.0.32
Comment on lines 2 to 4
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider updating version constraints for consistency

While the version constraints for fastapi, uvicorn, and gradio weren't changed in this PR, it might be worth considering updating them for consistency with the new approach used for ovos-plugin-manager and ovos-utils. The current constraints use the compatible release operator (~=), which is more restrictive than the new constraints.

For example, you might consider changing:

  • fastapi~=0.95 to fastapi>=0.95,<1.0.0
  • uvicorn~=0.22 to uvicorn>=0.22,<1.0.0
  • gradio~=3.28 to gradio>=3.28,<4.0.0

This would allow for a wider range of compatible versions while still maintaining upper bounds to prevent potential breaking changes from major version updates. However, please carefully consider the stability and compatibility of these packages before making such changes.

ovos-utils>=0.0.32,<1.0.0
flask