Skip to content

Commit

Permalink
fix:duplicate_handled_message
Browse files Browse the repository at this point in the history
ovos.utterance.handled is now emitted by the fallback pipeline, the skill class should not emit it or we get duplicate events

noticed in end2end tests from OpenVoiceOS/ovos-core#571
  • Loading branch information
JarbasAl committed Oct 31, 2024
1 parent 23e5650 commit 016e5cb
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions ovos_workshop/skills/fallback.py
Original file line number Diff line number Diff line change
Expand Up @@ -199,9 +199,6 @@ def _handle_fallback_request(self, message: Message):
self.bus.emit(message.forward(
f"ovos.skills.fallback.{self.skill_id}.response",
data={"result": status, "fallback_handler": handler_name}))
if status:
self.bus.emit(message.forward("ovos.utterance.handled",
{"handler": handler_name}))

def register_fallback(self, handler: callable, priority: int):
"""
Expand Down

0 comments on commit 016e5cb

Please sign in to comment.