Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAAS: Hetch #489

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

MAAS: Hetch #489

wants to merge 6 commits into from

Conversation

Amustache
Copy link
Contributor

No description provided.

@Amustache Amustache mentioned this pull request Jul 1, 2022
Closed
@Amustache Amustache requested a review from clementbiron July 1, 2022 16:00
@martinratinaud
Copy link
Member

@Amustache I fixed this PR as the selector you used was taking the header and footer into account, which is often not what's wanted.

Also, i removed executeClientScripts as it's not needed here.

Finally https://bolt.eu/fr/cookie-declaration/ is an empty page which is slightly different from others. I updated the document accordingly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinratinaud martinratinaud martinratinaud approved these changes

@clementbiron clementbiron Awaiting requested review from clementbiron

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Amustache @martinratinaud