Fix: Include information about relevant block in ScriptError message #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After already submitting this PR I noticed that mentioned error text is also present in some other Action2-related code. Since produce-block is based on this action, would it make sense to supplement those cases with mention of this block too? |
glx22
approved these changes
Jan 6, 2025
glx22
force-pushed
the
fix-produce-block-error
branch
from
edf807e to
3f5c3ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238, which refers to the error message in Action2 parser not containing
produce-blockas a relevant block.This is my first commit to this repository, I hope someone will guide me in case anything is not correctly presented.