-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename / remove dense and sparse variables and refactor #103
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very neat!
I think type annotations throughout would really help. Especially getting rid of None
instances where empty containers will just do the trick and allow simplifying the code. No need to include here, but probably a good one to tackle soon.
As discussed, we will further split the code-base into parts that are relevant only for simulation or solution. For this we will also split |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
_determine_dense_discrete_choice_axes
Future PRs:
discrete_problem._determine_dense_discrete_choice_axes
andsimulate.determine_discrete_dense_choice_axes
: They look similar, and do similar things, but not exactly -> Combine these with an argument likepurpose: Literal["solution", "simulation"]
.