Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the version number in conf.py. #154

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Fix the version number in conf.py. #154

merged 1 commit into from
Jul 21, 2024

Conversation

hmgaudecker
Copy link
Member

No description provided.

@hmgaudecker hmgaudecker requested a review from timmens July 21, 2024 11:04
Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eda143b) to head (c8f5d52).
Report is 11 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##             main      #154       +/-   ##
============================================
+ Coverage   58.49%   100.00%   +41.50%     
============================================
  Files           3        10        +7     
  Lines         159       131       -28     
============================================
+ Hits           93       131       +38     
+ Misses         66         0       -66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@timmens timmens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch; I forgot to update this!

@hmgaudecker
Copy link
Member Author

Why? Would have been my job when setting the release... Would be great if we could pull that dynamically at some point, but no rush (might switch from Sphinx to Jupyterbook eventually, but only when jb 2.0 is out, which will switch to mystmd as the backend instead of Sphinx).

@hmgaudecker hmgaudecker merged commit 99c9ce9 into main Jul 21, 2024
7 checks passed
@hmgaudecker hmgaudecker deleted the fix-docs-version branch July 21, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants