Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address review findings in bibliography.bib #75

Merged
merged 8 commits into from
Jun 10, 2024

Conversation

AMuetsch
Copy link
Contributor

@AMuetsch AMuetsch commented May 3, 2024

Reference to a related issue in the repository

Address review findings in #69

Add a description

  • Rename entry to "fmi2.0"
  • use "title" for title

Mention a member

@pmai

Check the checklist

  • I have performed a self-review of my own code/documentation.
  • My documentation changes are related to another repository in the organization. Here is the link to the issue/repo.
  • My changes generate no new warnings during the documentation generation.
  • The existing travis ci which pushes the documentation to gh-pages passes with my changes.

@pmai
Copy link
Contributor

pmai commented May 13, 2024

I've added and updated the remaining FMI/SSP entries, trying to align with ASAM guidelines w.r.t. standards.

@florianwallerer florianwallerer added documentation Everything which impacts the quality of the documentation and guidelines. ReadyForCCBReview labels Jun 3, 2024
@florianwallerer florianwallerer requested a review from pmai June 3, 2024 08:33
@florianwallerer
Copy link
Contributor

After merging thisone do not forget to merge #69

…e actual bibliography, which contains two wikipedia sources.
Copy link
Contributor

@florianwallerer florianwallerer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my side

@pmai pmai changed the base branch from fix_bibliography to master June 10, 2024 08:40
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OSI CCB 2024-06-10: Merge after conflict resolution by @pmai.

@pmai pmai merged commit cb2781b into OpenSimulationInterface:master Jun 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Everything which impacts the quality of the documentation and guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants