Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISO23150 compliance: Adding new states to [LaneBoundary – Classification - Type] #642

Open
FlorianMueller87 opened this issue Jun 9, 2022 · 3 comments · May be fixed by #658
Open

ISO23150 compliance: Adding new states to [LaneBoundary – Classification - Type] #642

FlorianMueller87 opened this issue Jun 9, 2022 · 3 comments · May be fixed by #658
Assignees
@jdsika
Labels
Harmonisation The Group in the ASAM development project working on harmonisation with other standards.

Comments

@FlorianMueller87
Copy link
Contributor

FlorianMueller87 commented Jun 9, 2022 •
edited
Loading

Describe the feature

ASAM OSI and ISO 23150 or AUTOSAR ADI have a common history. Unfortunately, the inner structure, the naming and the definitions of the standards are differentiated from each other. This makes the work of developers unnecessary complicated for mostly no technical reasons. All sides should strive to reduce inequality.

ASAM OSI need the entries for osi_lane – LaneBoundary – Classification - Type to be compatible with AUTOSAR ADI RoadBoundaryType.

Describe the solution you would like

Add in osi_lane – LaneBoundary – Classification - Type the following entries:
// The lane boundary is a fence.
//
TYPE_FENCE = 16;

// The lane boundary is a tension cable system.
//
TYPE_TENSION_CABLE_SYSTEM = 17;

Describe alternatives you have considered

No alternative was considered.

Describe the backwards compatibility

The adding of the elements will not lead to backward compatibility issues.

Additional context

ISO23150:2021 A.2.102 Road boundary type
@ThomasNaderBMW @jdsika @schmidtlorenz
@jdsika jdsika self-assigned this Jun 15, 2022
@jdsika jdsika added the Harmonisation The Group in the ASAM development project working on harmonisation with other standards. label Jun 15, 2022
@pmai
Copy link
Contributor

pmai commented Jul 8, 2022

Note that a wand is something wizards wield, not something commonly found on roads, so I'm rather hoping that ADI does not use this term...

In any case this is redundant to TYPE_STRUCTURE that we already have.

TYPE_FENCE and TYPE_TENSION_CABLE_SYSTEM might be added, though at least for the later it is likely debatable whether that is not for all practical purposes subsumed by guard rail, unless it is specified more clearly.

@FlorianMueller87
Copy link
Contributor Author

kWand is obviously a mistake in the ADI spec. We will change this, thanks.

@jdsika
Copy link
Contributor

jdsika commented Aug 2, 2022

I was totally in favor of the kWand... 👍🏻

FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 5, 2022
@FlorianMueller87
Added two new elements to LaneBoundary-Classification-Type: FENCE and…
23fd02a 
… TENSION_CABLE_SYSTEM

Issue: OpenSimulationInterface#642
@FlorianMueller87 FlorianMueller87 linked a pull request Aug 5, 2022 that will close this issue
Open
6 tasks
FlorianMueller87 added a commit to FlorianMueller87/open-simulation-interface that referenced this issue Aug 12, 2022
@FlorianMueller87
Added two new elements to LaneBoundary-Classification-Type: FENCE and…
7088b2c 
… TENSION_CABLE_SYSTEM

Issue: OpenSimulationInterface#642
Signed-off-by: FlorianMueller87 <[email protected]>
@jdsika jdsika linked a pull request Oct 17, 2022 that will close this issue
Draft for discussion: Feature/add elements to lane boundary classification type #658
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdsika jdsika

Labels
Harmonisation The Group in the ASAM development project working on harmonisation with other standards.
Projects
None yet
Milestone
No milestone
3 participants
@pmai @jdsika @FlorianMueller87