Serial Input Handler Cleanup and Improvements #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMT Pin to RF TX Pin Start of Serial Echo while typing More reliable handling of pasted commands Add alias for restart Add RTOS debug info command Switching to case-insensitive checks for command names Clearing serial buffer Allow adding networks without ID parameter in JSON
hhvrc
previously approved these changes
Dec 13, 2023
LucHeart
pushed a commit
that referenced
this pull request
Jan 22, 2024
* Start of Serial Input Handler cleanup: RMT Pin to RF TX Pin Start of Serial Echo while typing More reliable handling of pasted commands Add alias for restart Add RTOS debug info command Switching to case-insensitive checks for command names Clearing serial buffer Allow adding networks without ID parameter in JSON * Make Serial Echo toggleable, add Init to Serial Input Handler * Add comments and always print out buffer being processed * Serial "Debug Info" command * Add missing Time.h inclusion * Add uptime to debug info command * Better ip address printing * Fix const violation error * IPAddress doesnt have implicit uint8_t* operator * Use BSSID FormatHelpers, Add On/Off to bool check * Remove multiple input options * Concise wording * Change "txpin" to "rftxpin" --------- Co-authored-by: HentaiHeavenVR <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup, Echo when typing, better case-insensitivity, optional IDs for networks, better handle pasted commands (and multi line pastes), etc!
Just a bunch of QoL I wanted while working on other changes.