Better checking for shocker types, fix rmt sending causing crashes #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhvrc
approved these changes
Dec 5, 2023
hhvrc
added
type: bug
LucHeart
pushed a commit
that referenced
this pull request
Jan 22, 2024
) * Better checking for shocker types, fix rmt sending causing crashes * Actually fix RMT binary encoder crash * Move string compare logic to common method --------- Co-authored-by: hhvrc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to case-insensitive checking for shocker model
And fixes crashes when sending RMT to either model