Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Applicant FAQ to OpenSats.org #401

Merged
merged 23 commits into from
Feb 6, 2025
Merged

Add Applicant FAQ to OpenSats.org #401

merged 23 commits into from
Feb 6, 2025

Conversation

Arvin21M
Copy link
Contributor

@Arvin21M Arvin21M commented Feb 4, 2025 •
edited by dergigi
Loading

Build preview:

@vercel Vercel
Copy link

vercel bot commented Feb 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
os-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 6, 2025 0:20am

@Arvin21M Arvin21M requested a review from dergigi February 4, 2025 18:53
@Arvin21M Arvin21M added the enhancement New feature or request label Feb 4, 2025
@dergigi
Copy link
Member

dergigi commented Feb 4, 2025

Created the route and fixed some things.

Please have a look:

Arvin21M
Arvin21M commented Feb 4, 2025
View reviewed changes
Copy link
Contributor Author

@Arvin21M Arvin21M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All the links working/pointing to right destination. Including footnote.
  • All content from draft included.
  • The edits, additions, and other changes made are reflected in the build preview.
  • Looks great to me :shipit:

@dergigi
Copy link
Member

dergigi commented Feb 6, 2025

Awesome, thanks for having another look Arvin 🙏🧡

I just added some links so that the FAQ is actually reachable, and added a link to the license list we usually send to applicants. I'll do another quick sanity check myself and will ship it :shipit: - none of the changes are critical, in case something is off or broken we can fix it with a small follow-up PR.

@dergigi dergigi merged commit 14355ec into master Feb 6, 2025
3 checks passed
@dergigi dergigi deleted the Arvin21M-patch-1 branch February 6, 2025 12:22
jonatack
jonatack reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@jonatack jonatack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! modulo one comment below.

data/pages/faq-application.mdx Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonatack jonatack jonatack left review comments

@moteanup24 moteanup24 moteanup24 left review comments

@dergigi dergigi Awaiting requested review from dergigi

Assignees

@dergigi dergigi

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Arvin21M @dergigi @jonatack @moteanup24