Small fixes and improvement for mac users on the docker pr-test file and script #9343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #9343 +/- ##
============================================
- Coverage 39.34% 39.33% -0.02%
Complexity 2267 2267
============================================
Files 1301 1301
Lines 98165 98165
Branches 3297 3297
============================================
- Hits 38626 38616 -10
- Misses 57591 57601 +10
Partials 1948 1948
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bougue-pe
reviewed
Oct 15, 2024
EthanPERRUZZA
force-pushed
the
eth/pr-test-mac
branch
from
4e0df5e to
36004a9
Compare
bougue-pe
reviewed
Oct 16, 2024
EthanPERRUZZA
force-pushed
the
eth/pr-test-mac
branch
from
23e8548 to
9e243f2
Compare
bougue-pe
reviewed
Oct 17, 2024
Signed-off-by: Ethan Perruzza <[email protected]>
…ac users for better performances Signed-off-by: Ethan Perruzza <[email protected]>
…e pr test script Signed-off-by: Ethan Perruzza <[email protected]>
… wasn't already launched anymore, it's volume is erased similarly to the dev behaviour Signed-off-by: Ethan Perruzza <[email protected]>
Signed-off-by: Ethan Perruzza <[email protected]>
EthanPERRUZZA
force-pushed
the
eth/pr-test-mac
branch
from
9e243f2 to
d4d5d43
Compare
Khoyo
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test it is necessary to use a very recent PR (as an env var has been changed with the switch to Valkey from Redis making the script unusable for not rebased PR's)
It can be test with the 9343 PR and it works for me