Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DCO #231

Merged
merged 2 commits into from
Sep 9, 2024
Merged

DCO #231

merged 2 commits into from
Sep 9, 2024

Conversation

EthanPERRUZZA
Copy link
Contributor

No description provided.

@EthanPERRUZZA EthanPERRUZZA force-pushed the dco branch 3 times, most recently from bfd341e to c10c2f4 Compare September 5, 2024 13:22
ElysaSrc
ElysaSrc approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Careful few typos here and there but that seems good to me.

Ping @flomonster for review if this matches what was expected on the website.

content/docs/guides/contribute/contribute-code/commit-conventions.en.md Outdated Show resolved Hide resolved
content/docs/guides/contribute/contribute-code/commit-conventions.en.md Outdated Show resolved Hide resolved
@EthanPERRUZZA EthanPERRUZZA force-pushed the dco branch 2 times, most recently from c6306da to 3c2b7a5 Compare September 5, 2024 13:40
@EthanPERRUZZA EthanPERRUZZA marked this pull request as ready for review September 5, 2024 14:00
@EthanPERRUZZA EthanPERRUZZA force-pushed the dco branch 2 times, most recently from 769d9ba to dc436a4 Compare September 5, 2024 14:15
@emersion emersion mentioned this pull request Sep 5, 2024
Merged
flomonster
flomonster reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your pull requests. It looks good to me overal, just a few comments.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
content/docs/guides/contribute/contribute-code/commit-conventions.en.md Outdated Show resolved Hide resolved
flomonster
flomonster approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can resolve the remaining open conversation

This was referenced Sep 6, 2024
Merged
Merged
@ElysaSrc ElysaSrc merged commit b214168 into master Sep 9, 2024
2 checks passed
@ElysaSrc ElysaSrc deleted the dco branch September 9, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElysaSrc ElysaSrc ElysaSrc approved these changes

@flomonster flomonster flomonster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EthanPERRUZZA @flomonster @ElysaSrc