Add support for Rocky8, Rocky9, Ubuntu build #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
velomatt
commented
Jul 25, 2024
velomatt
commented
- Add dependency installation scripts to support CentOS 7, Rocky8, Rocky9, and Ubuntu 22 build
- Update README to reflect changes
- Minor changes to support newer GCC compiler
- Add dockerfiles for each supported distro / OS
- Support CentOS, Rocky8, Rocky9 - Install all deps automatically in docker env - Update README
These deps are now installed via scripts/dependencies/install.sh
- need to explicitly import string - need boost/cstdint.hpp for uint64_t
- use env var to determine docker optimizations - set env var in dockerfile - fix missing && before rm dependencies dir - set vault yum repos for centos (EOL) - remove unneeded redhat-lsb dep from cent
- merge centos and rocky - use symlink from centos to rocky
- Sonar is not consistent so I can't derive the dir name any other way
- minor formatting improvements - add submodule instructions - add build script instructions
- update docs to streamline use of workdir for the sake of clarity
|
|
NKV cli changes look good to me. |
| // Initialize class object | ||
| nkv_lruCache<std::string, nkv_value_wrapper> *cache_obj | ||
| = new nkv_lruCache<std::string, nkv_value_wrapper>(nkv_read_cache_size); | ||
| cnt_cache.push_back(cache_obj); |
There was a problem hiding this comment.
Instead of pushing back we just need to access cnt_cache[i].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.