Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation by removing template id from constructor #1989

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix compilation by removing template id from constructor #1989

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
321731c
Fix compilation error due to template id in constructor
aroffringa Jan 19, 2025
4006f21
Add missing &
aroffringa Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions include/ola/thread/FuturePrivate.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@ class FutureImpl {
bool m_is_set;
T m_value;

DISALLOW_COPY_AND_ASSIGN(FutureImpl<T>);
FutureImpl(const FutureImpl<T>&) = delete;
FutureImpl<T>& operator=(const FutureImpl<T>&) = delete;
};

/**
Expand Down Expand Up @@ -152,7 +153,8 @@ class FutureImpl<void> {
unsigned int m_ref_count;
bool m_is_set;

DISALLOW_COPY_AND_ASSIGN(FutureImpl<void>);
FutureImpl(const FutureImpl<void>&) = delete;
FutureImpl<void>& operator=(const FutureImpl<void>&) = delete;
};

} // namespace thread
Expand Down
Loading