Issue455 refresh issue due to pom generated in target on building the project #462
Conversation
| @@ -32,7 +32,7 @@ export const COMMAND_AND_PROJECT_TYPE_MAP: { [command: string]: string[] } = { | |||
| "gradle":[ LIBERTY_GRADLE_PROJECT, LIBERTY_GRADLE_PROJECT_CONTAINER], | |||
| "liberty.dev.debug": [LIBERTY_MAVEN_PROJECT, LIBERTY_GRADLE_PROJECT, LIBERTY_MAVEN_PROJECT_CONTAINER, LIBERTY_GRADLE_PROJECT_CONTAINER], | |||
| }; | |||
| export const EXCLUDED_DIR_PATTERN = "**/{bin,classes,target}/**"; | |||
| export const EXCLUDED_DIR_PATTERN = "**/{bin,classes,target,build}/**"; | |||
There was a problem hiding this comment.
What is EXCLUDED_DIR_PATTERN used for? I see that target was already included, so this must not be working for the refresh scenario. What is the reason for adding build here?
| // Listens for any new folders are added to the workspace | ||
| context.subscriptions.push(vscode.workspace.onDidChangeWorkspaceFolders((event) => { | ||
| // Listens for any new folders are added to the workspace | ||
| context.subscriptions.push(vscode.workspace.onDidChangeWorkspaceFolders((event) => { |
There was a problem hiding this comment.
Please do not modify spacing or formatting on existing code, unless it is in a separate PR specific to formatting changes. It is not immediately clear if there are any functional changes in the middle of formatting changes, which makes code more difficult to review and makes it more difficult for others to understand when looking back at code history.
| * @returns | ||
| */ | ||
| export function isInTargetOrBuild(filePath: string): boolean { | ||
| return filePath.includes('/target/') || filePath.includes('/build/'); |
There was a problem hiding this comment.
I don't think this is valid if it is just any "target" or "build" dir. We need to ensure the file/path is in a subdirectory of the project's "target" or "build" directory (i.e. the "target" or "build" directory located in the root project folder).
| projectProvider.refresh(); | ||
| }); | ||
| } | ||
|
|
There was a problem hiding this comment.
I am not entirely sure about this approach, since we are still watching the "target" and "build" dirs. It would be better if we could find a way to ignore them completely.
There was a problem hiding this comment.
can we add '&&' operator in vscode.workspace.createFileSystemWatcher?
Did conditions like this work '**/pom.xml && !inside target folder' ?
Fixes #455