add support for new jakarta LS/Client message - fileInfo #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrevCraw
reviewed
Oct 30, 2023
src/extension.ts
Outdated
| @@ -76,6 +76,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<void> | |||
| console.log("LSP4Jakarta is ready, binding requests..."); | |||
|
|
|||
| // Delegate requests from Jakarta LS to the Jakarta JDT core | |||
| bindRequest(lsp4jakartaLS.FILEINFO_REQUEST); | |||
There was a problem hiding this comment.
please fix spacing if possible
ajm01
force-pushed
the
pickup-new-jakarta-msg
branch
from
799655b to
6cec40f
Compare
TrevCraw
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there is a new "jakarta/java/fileInfo" message supported between LS and LSClient to get the package name for the file that is currently having a snippet inserted into it. This was not functioning in the vscode env because the config for that new message was missing from the DelegateCommandHandler and the vscode client config as well. Added this support so that package name can be obtained from the jakarta JDT LS extn. There is a separate PR int he liberty-tools-vscode repo to pick up the tool config side of this.
This PR cannot be merged/built until eclipse-lsp4jakarta/lsp4jakarta#501 is reviewed/merged and a lsp4jakarta snapshot is respun.