-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Refreshing Liberty Dashboard projects" kicks in all the time #455
Comments
Raised PR #456 |
Hi @sdehors-ibm, thank you for raising this issue and opening a PR to address it. Given the time of the year, we will have someone on our team take a closer look next week. Based on your description of the issue, we may consider a solution beyond providing an option to users to disable the refresh. We may need to update our default behaviour. |
@TrevCraw , sure I proposed this to unlock our adoption of VScode + liberty tools but ideally the refresh should only be triggered when appropriate. |
Hi @sdehors-ibm , when i tried the build i was not able to see any pom files getting generated in the target folder , also checked if refresh is getting invoked during the build but seems like it isn't . Not sure what i'm missing here. Can you share the steps you tried for which you got this issue? |
Initially made a few changes to avoid looking into target and build directories for wherever there is a reference for pom.xml or build.gradle in the extension which didn't seem to fix the issue . |
The extension listens to changes on /pom.xml,/build.gradle,/settings.gradle,/src/main/liberty/config/server.xml as well as changes in workspace folders.
On some of the projects that we have, when the java build kicks in, the liberty dashboard refresh is triggered. This is certainly due to the fact that our build generates some pom files in the target folder. This seems to interrupt the java build that then restarts from the beginning, causing some kind of infinite loop.
On a given project we do not change the liberty config often once established. It should be possible to disable the automatic refresh as its causing a lot of interruptios
The text was updated successfully, but these errors were encountered: