-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #534: Refactored quick fixes and test cases for RemoveParamsProposal #575
Fixes #534: Refactored quick fixes and test cases for RemoveParamsProposal #575
Conversation
...penliberty/tools/intellij/lsp4jakarta/lsp4ij/codeAction/proposal/RemoveElementsProposal.java
Outdated
Show resolved
Hide resolved
...rty/tools/intellij/lsp4jakarta/lsp4ij/jax_rs/ResourceMethodMultipleEntityParamsQuickFix.java
Outdated
Show resolved
Hide resolved
...rty/tools/intellij/lsp4jakarta/lsp4ij/jax_rs/ResourceMethodMultipleEntityParamsQuickFix.java
Outdated
Show resolved
Hide resolved
...rty/tools/intellij/lsp4jakarta/lsp4ij/jax_rs/ResourceMethodMultipleEntityParamsQuickFix.java
Outdated
Show resolved
Hide resolved
@dessina-devasia On the most recent build I see that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments for requested changes.
eb316c1
to
c15bca7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that my previous comments were addressed. Looks good. Thanks.
…urceMethodMultipleEntityQuickFix
…ethodParametersQuickFix
…uctAnnotatationTest
d22ea05
bb02fb9
to
d22ea05
Compare
4ea0b15
into
OpenLiberty:code-action-unification-2
Fixes #534
Refactored quick fixes and test cases for RemoveParamsProposal