Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #534: Refactored quick fixes and test cases for RemoveParamsProposal #575

Conversation

dessina-devasia
Copy link
Contributor

Fixes #534
Refactored quick fixes and test cases for RemoveParamsProposal

@mrglavas
Copy link
Contributor

mrglavas commented Dec 4, 2023

@dessina-devasia On the most recent build I see that PostConstructAnnotationTest is failing on all platforms. Will need to resolve this before this PR can be merged.

Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments for requested changes.

@dessina-devasia dessina-devasia force-pushed the 534-RemoveParamsProposal-quick-fixes-new branch from eb316c1 to c15bca7 Compare December 8, 2023 08:09
vaisakhkannan
vaisakhkannan previously approved these changes Jan 18, 2024
Copy link
Contributor

@vaisakhkannan vaisakhkannan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dessina-devasia dessina-devasia removed the request for review from aparnamichael January 18, 2024 14:36
@TrevCraw TrevCraw requested a review from mrglavas January 18, 2024 19:09
mrglavas
mrglavas previously approved these changes Jan 22, 2024
Copy link
Contributor

@mrglavas mrglavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that my previous comments were addressed. Looks good. Thanks.

@dessina-devasia dessina-devasia removed the request for review from vaisakhkannan January 25, 2024 12:29
@dessina-devasia dessina-devasia requested review from vaisakhkannan and removed request for vaisakhkannan January 25, 2024 12:30
@dessina-devasia dessina-devasia merged commit 4ea0b15 into OpenLiberty:code-action-unification-2 Jan 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants