Merge code-action-unification branch into main #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… EE code actions. Signed-off-by: Michael Glavassevich <[email protected]>
… and corrects a problem with the code change computed by the quick fix. Signed-off-by: Michael Glavassevich <[email protected]>
1. Implemented IJavaCodeActionParticipant 2. Made the class abstract
…ngType quick fix Added extension point and enabled the tests
…tQuickFix and bring the test ready
…stConstructReturnTypeQuickFix.
…n method in PostConstructAnnotationTest
…#514 Refactored the code to implement the code action participant extension point. Jakarta EE code action tests enabled.
This reverts commit 9f6efa4.
mrglavas
approved these changes
Oct 21, 2023
turkeylurkey
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains content that was previously reviewed and tested before it was merged into the code-action-unification branch. 11 Jakarta EE code actions have been transformed to share the same design as the MP code actions and are loaded using extension points in the same way.
Summary of changes to unify the design of code actions
IJavaCodeActionParticipant.JavaCodeActionDefinitionby adding a group field to distinguish between code actions for different language servers (e.g. MP vs. Jakarta EE)CodeActionHandlerto use this field when filtering the list of code actions.CodeActionHandlerinto thePropertiesManagerForJakarta, replacing the usage of the Jakarta EEJakartaCodeActionHandler.javaCodeActionParticipants in theplugin.xmlfor the Jakarta EE code actions and updated all of the existingjavaCodeActionParticipants to specify that those code actions apply to MicroProfile by adding the group field.