Fixes #517 Implement Code Action Participant in HttpServletQuickFix #532
Conversation
Rahul-Biju
changed the title
| public List<? extends CodeAction> getCodeActions(JavaCodeActionContext context, Diagnostic diagnostic) { | ||
| List<CodeAction> codeActions = new ArrayList<>(); | ||
| PsiElement node = context.getCoveredNode(); | ||
| PsiClass parentType = getBinding(node); | ||
| if (parentType != null) { |
There was a problem hiding this comment.
This null check is required. Please add this back to the code so that an empty list of code actions is returned if there is no parent type.
There was a problem hiding this comment.
@mrglavas addressed the review comments.
| String newText = "package io.openliberty.sample.jakarta.servlet;\n\n" + | ||
| "import jakarta.servlet.annotation.WebServlet;\nimport jakarta.servlet.http.HttpServlet;\n\n" + | ||
| "@WebServlet(name = \"demoServlet\", urlPatterns = {\"/demo\"})\n" + | ||
| "public class DontExtendHttpServlet extends HttpServlet {\n\n}"; | ||
|
|
||
| TextEdit te = JakartaForJavaAssert.te(0, 0, 7, 1, newText); |
There was a problem hiding this comment.
You don't seem to have enabled this portion of the test in your PR. I can see it's still inside a block of code that won't be executed. I would suggest looking at some of the other PRs to see how others have been enabling tests for code actions.
There was a problem hiding this comment.
@mrglavas addressed the review comments.
| group="jakarta" | ||
| targetDiagnostic="jakarta-cdi#InvalidManagedBeanConstructor" | ||
| implementationClass="io.openliberty.tools.intellij.lsp4jakarta.lsp4ij.cdi.ManagedBeanNoArgConstructorQuickFix"/> | ||
|
|
There was a problem hiding this comment.
are these quick fixes intended to be added?
There was a problem hiding this comment.
@TrevCraw addressed the review comments.
Rahul-Biju
merged commit a737c10
into
OpenLiberty:code-action-unification
Fixes #517 Implement Code Action Participant in HttpServletQuickFix.