Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #35

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Dev #35

merged 9 commits into from
Mar 4, 2024

Conversation

KarenAJ
Copy link
Contributor

@KarenAJ KarenAJ commented Feb 29, 2024

Description: Describe in a couple of sentences how this pull request modifies the repository. Comment on the business context, and highlight any concerns about the changes being introduced.

Issue: Provide the URL for a corresponding issue/work ticket, if applicable.

Dependencies: List dependencies on open pull requests, other issue/work tickets, etc.

Merge Deadline: Indicate the merge deadline date.

Pre-Merge Checklist:

  • I have ensured this code follows the style guidelines of this project.
  • I have performed a comprehensive self-review of the code.
  • I have included comments clarifying hard-to-understand areas of the code.
  • I have updated the documentation corresponding to my change(s).
  • I have confirmed the code executes properly on my local environment.
  • I have confirmed all new/modified data models are structured correctly.
  • I have included all necessary database migration files.
  • I have verified that all new and existing tests pass.
  • I have received approval from the requisite number of reviewers.
  • I have squashed all working commits into as few final commits as reasonably possible.
  • I have confirmed Github reports all automated tests/checks are passing.

Post-Merge Checklist:

  • Delete working branch @ Github repository
  • Pull latest master branch to local repository
  • Delete working branch @ local repository

@KarenAJ KarenAJ requested review from schittlur, JDTobin and sammy-sandhu and removed request for schittlur, JDTobin and sammy-sandhu March 4, 2024 17:47
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
4 Security Hotspots
0.0% Coverage on New Code (required ≥ 80%)
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@KarenAJ KarenAJ requested review from JDTobin, sammy-sandhu and schittlur and removed request for schittlur, JDTobin and sammy-sandhu March 4, 2024 19:41
@KarenAJ KarenAJ merged commit aeaba67 into main Mar 4, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants