Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse dcat license field #40

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Conversation

jguo144
Copy link
Collaborator

@jguo144 jguo144 commented Apr 2, 2024

Description

If the license field exists in the DCAT data.json file then try to map it to a license available in CKAN's license list.

Copy link

@orca-security-us orca-security-us bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.49%. Comparing base (ba43d5c) to head (ef23155).

Files Patch % Lines
ckanext/dcat/converters.py 55.55% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   92.54%   92.49%   -0.05%     
==========================================
  Files          38       38              
  Lines        7003     7012       +9     
==========================================
+ Hits         6481     6486       +5     
- Misses        522      526       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@scastineyras scastineyras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I saw the crd, was this field there before, and now we are adding it again, or it was never here?

@scastineyras scastineyras merged commit f5b59a7 into master Apr 3, 2024
13 checks passed
@scastineyras scastineyras deleted the jguo144/2024-04-01/parse-license branch April 3, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants