Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent writing of file if request was not successful #78

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jjnesbitt
Copy link
Member

@jjnesbitt jjnesbitt commented Oct 1, 2024

Currently, the request to retrieve certain files from DKC often fails with a 502 Bad Gateway, but the file is still written to anyway. Since the file is only written to the first time, this means that if this bad request happens when first running populate, the bad file will remain there until the file item is deleted.

@jjnesbitt jjnesbitt requested a review from annehaley October 1, 2024 20:50
Copy link
Collaborator

@annehaley annehaley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree we should add this line, but I'm not sure it closes the issue. Tests that encounter the nginx 502 error will still fail, albeit with a more informative exception raised.

@jjnesbitt
Copy link
Member Author

I agree we should add this line, but I'm not sure it closes the issue. Tests that encounter the nginx 502 error will still fail, albeit with a more informative exception raised.

You're right, it more just fixes the issue for local dev, since you can just re-run it until it succeeds. I'll remove the link to that issue so this PR won't close it, and reword the issue a bit.

@jjnesbitt jjnesbitt merged commit 82dd93c into master Oct 1, 2024
4 checks passed
@jjnesbitt jjnesbitt deleted the fix-ingest-use-case branch October 1, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants