Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use babel in the build process. #900

Merged
merged 4 commits into from
Aug 23, 2018
Merged

Use babel in the build process. #900

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77bcec4
Use babel in the build process.
manthey Jul 11, 2018
b21f208
Use babel 7 and babel polyfills.
manthey Aug 21, 2018
5c9c1d7
Use babel 6 and move where babel-polyfills are added.
manthey Aug 22, 2018
c303a85
Remove a commented out line. Update change log.
manthey Aug 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions karma-cov.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,16 +34,17 @@ module.exports = function (config) {
karma_config.specReporter = {suppressPassed: true, suppressSkipped: true};
karma_config.coverageReporter = {
reporters: [
{type: 'html', dir: 'dist/coverage/', subdir: subdir_name},
// {type: 'html', dir: 'dist/coverage/', subdir: subdir_name},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless there's a good reason, we should probably remove unused lines rather than commenting them out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do. Thanks.

{type: 'cobertura', dir: 'dist/cobertura/', file: 'coverage.xml', subdir: subdir_name},
{type: 'json', dir: 'dist/coverage/json/', subdir: subdir_name},
{type: 'lcovonly', dir: 'lcov', subdir: subdir_name},
{type: 'lcovonly', dir: 'dist/coverage/lcov', subdir: subdir_name},
{type: 'text'}
]
};
karma_config.webpack.module.rules.unshift({
test: /\.js$/,
include: path.resolve('src/'),
exclude: path.resolve('src/polyfills.js'),
use: ['istanbul-instrumenter-loader']
});

Expand Down
Loading