Add keyboard support for map interaction. #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add some css to show when the map gets focus. This is only added if the map has the appropriate class, which is controlled by a flag in the keyboard settings for the interactor.
Current coverage is 89.01% (diff: 100%)@@ master #661 diff @@
==========================================
Files 84 84
Lines 8497 8582 +85
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 7550 7639 +89
+ Misses 947 943 -4
Partials 0 0
|
aashish24
reviewed
Jan 23, 2017
| } | ||
| } | ||
| } | ||
| console.log(JSON.stringify([meta, evt, factor])); //DWM:: |
aashish24
approved these changes
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some css to show when the map gets focus. This is only added if the map has the appropriate class, which is controlled by a flag in the keyboard settings for the interactor.
As some background for this PR, having keyboard control is desirable for annotation editing, as it will allow precise nudging of locations.