1104 gather check json files #1112
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her-check_json_files
jthorton
reviewed
Feb 7, 2025
openfecli/commands/gather.py
Outdated
Comment on lines
105
to
115
| if "unit_results" not in result.keys(): | ||
| click.echo(f"{fpath}: No 'unit_results' found, assuming to be a failed simulation.", err=True) | ||
|
|
||
| if all('exception' in u for u in result['unit_results'].values()): | ||
| click.echo(f"{fpath}: Exception found in 'unit_results', assuming to be a failed simulation.", err=True) | ||
|
|
||
| if result['estimate'] is None: | ||
| click.echo(f"No{fpath}: No 'estimate' found, assuming to be a failed simulation", err=True) | ||
|
|
||
| if result['uncertainty'] is None: | ||
| click.echo(f"{fpath}: No 'uncertainty' found, assuming to be a failed simulation", err=True) |
There was a problem hiding this comment.
If an edge has failed this will print all of these messages for that edge? It would be best to have a single message per edge indicating if it has failed.
jthorton
reviewed
Feb 7, 2025
Co-authored-by: Josh Horton <[email protected]>
|
No API break detected ✅ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1104
Checklist
newsentryDevelopers certificate of origin