Skip to content

Commit

Permalink
Multistate analysis fix
Browse files Browse the repository at this point in the history
  • Loading branch information
IAlibay committed Feb 3, 2025
1 parent 5b2b633 commit 8c1704c
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion environment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ dependencies:
- click
- typing-extensions
- openmm >=8.0.0,!=8.1.0,<8.2.0
- openmmtools
- openmmtools <0.24.1
- openmmforcefields
- perses>=0.10.3
- pooch
Expand Down
2 changes: 1 addition & 1 deletion openfe/protocols/openmm_rfe/equil_rfe_methods.py
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,7 @@ def structural_analysis(scratch, shared) -> dict:
data["protein_2D_RMSD"], dtype=np.float32
),
time_ps=np.asarray(
data["time(ps)"], dtype=np.int32
data["time(ps)"], dtype=np.float32
),
)

Expand Down
6 changes: 2 additions & 4 deletions openfe/tests/protocols/test_openmm_rfe_slow.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# This code is part of OpenFE and is licensed under the MIT license.
# For details, see https://github.com/OpenFreeEnergy/openfe
import numpy as np
from numpy.testing import assert_equal
from numpy.testing import assert_allclose

Check warning on line 4 in openfe/tests/protocols/test_openmm_rfe_slow.py

View check run for this annotation

Codecov / codecov/patch

openfe/tests/protocols/test_openmm_rfe_slow.py#L4

Added line #L4 was not covered by tests
from gufe.protocols import execute_DAG
import pytest
from openff.units import unit
Expand Down Expand Up @@ -111,9 +111,7 @@ def test_openmm_run_engine(benzene_vacuum_system, platform,
assert key in structural_data.keys()

# 6 frames being written to file
# Note: the values of this next test are wrong, but in an expected way
# See: https://github.com/OpenFreeEnergy/openfe_analysis/issues/33
assert_equal(structural_data['time_ps'], [0, 50, 100, 150, 200, 250])
assert_allclose(structural_data['time_ps'], [0.0, 0.02, 0.04, 0.06, 0.08, 0.1])

Check warning on line 114 in openfe/tests/protocols/test_openmm_rfe_slow.py

View check run for this annotation

Codecov / codecov/patch

openfe/tests/protocols/test_openmm_rfe_slow.py#L114

Added line #L114 was not covered by tests
assert structural_data['ligand_RMSD'].shape == (11, 6)
assert structural_data['ligand_COM_drift'].shape == (11, 6)
# No protein so should be empty
Expand Down

0 comments on commit 8c1704c

Please sign in to comment.