85 review docstrings #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
=======================================
Coverage 86.81% 86.81%
=======================================
Files 49 49
Lines 1577 1577
=======================================
Hits 1369 1369
Misses 208 208 ☔ View full report in Codecov by Sentry. |
RiesBen
reviewed
Oct 29, 2024
src/konnektor/network_planners/concatenators/cyclic_concatenator.py
Outdated
Show resolved
Hide resolved
src/konnektor/network_planners/generators/clustered_network_generator.py
Show resolved
Hide resolved
atravitz
commented
Nov 12, 2024
There was a problem hiding this comment.
@hannahbaumann could you take a look at these last two open conversations?
src/konnektor/network_planners/generators/clustered_network_generator.py
Show resolved
Hide resolved
hannahbaumann
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Here my comments on the two open questions, will go through the rest later. Maybe we can also meet and discuss @atravitz , I'm also not fully sure yet.
hannahbaumann
requested changes
Nov 13, 2024
src/konnektor/network_planners/generators/_abstract_network_generator.py
Outdated
Show resolved
Hide resolved
src/konnektor/network_planners/generators/cyclic_network_generator.py
Outdated
Show resolved
Hide resolved
src/konnektor/network_planners/generators/maximal_network_generator.py
Outdated
Show resolved
Hide resolved
src/konnektor/network_planners/generators/redundant_minimal_spanning_tree_network_generator.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Hannah Baumann <[email protected]>
atravitz
force-pushed
the
85-review-docstrings
branch
from
93d133a to
ae0973b
Compare
… parent class" This reverts commit ae0973b.
IAlibay
approved these changes
Nov 20, 2024
src/konnektor/network_planners/generators/_abstract_network_generator.py
Outdated
Show resolved
Hide resolved
src/konnektor/network_planners/generators/_abstract_network_generator.py
Outdated
Show resolved
Hide resolved
src/konnektor/network_planners/generators/maximal_network_generator.py
Outdated
Show resolved
Hide resolved
src/konnektor/network_planners/generators/maximal_network_generator.py
Outdated
Show resolved
Hide resolved
src/konnektor/network_planners/generators/minimal_spanning_tree_network_generator.py
Show resolved
Hide resolved
This was referenced Dec 2, 2024
|
@hannahbaumann this is ready for re-review. I moved out-of-scope items into follow-up issues. CI is failing on one test, but it's also failing on main and I have an issue open to address it. |
src/konnektor/network_planners/generators/cyclic_network_generator.py
Outdated
Show resolved
Hide resolved
src/konnektor/network_planners/generators/clustered_network_generator.py
Outdated
Show resolved
Hide resolved
hannahbaumann
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Thanks @atravitz , lgtm once CI and docs build are passing!
…nerator.py Co-authored-by: Hannah Baumann <[email protected]>
…ator.py Co-authored-by: Hannah Baumann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some typo and grammar fixes, as well as some questions.