Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AtomMappingError #440

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Add AtomMappingError #440

merged 5 commits into from
Jan 7, 2025

Conversation

jthorton
Copy link
Contributor

@jthorton jthorton commented Dec 10, 2024

Fixes #419. This error should be raised by the derived atom mappers when there is an issue generating mappings.

Tips

  • Comment "pre-commit.ci autofix" to have pre-commit.ci atomically format your PR.
    Since this will create a commit, it is best to make this comment when you are finished with your work.

Checklist

  • Added a news entry

Developers certificate of origin

@jthorton jthorton requested a review from dotsdl December 10, 2024 13:12
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.51%. Comparing base (21b1382) to head (378a11e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #440   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          37       38    +1     
  Lines        2156     2158    +2     
=======================================
+ Hits         2124     2126    +2     
  Misses         32       32           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jthorton
Copy link
Contributor Author

pre-commit.ci autofix

@ijpulidos ijpulidos self-requested a review December 16, 2024 19:19
@dotsdl dotsdl enabled auto-merge (squash) January 7, 2025 16:53
@dotsdl dotsdl merged commit 71a9c66 into main Jan 7, 2025
13 checks passed
@dotsdl dotsdl deleted the mapping_error branch January 7, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a generic AtomMappingError
3 participants