Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear dataclip input when user saves workflow #2979

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

midigofrank
Copy link
Collaborator

Description

This PR fixes an issue where the dataclip input was being cleared whenever the user clicks to save the workflow

Closes #2944

Validation steps

  1. Open up the job inspector
  2. Enter your dataclip input
  3. Click to save the workflow. Notice that the dataclip is still present

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@midigofrank midigofrank self-assigned this Feb 28, 2025
@midigofrank
Copy link
Collaborator Author

Hey @jyeshe I've added you as a reviewer because this issue is related to the one you're handling: #2952

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.61%. Comparing base (83443d2) to head (740bc44).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2979   +/-   ##
=======================================
  Coverage   91.61%   91.61%           
=======================================
  Files         346      346           
  Lines       12742    12751    +9     
=======================================
+ Hits        11673    11682    +9     
  Misses       1069     1069           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuartc stuartc merged commit 635ade1 into main Feb 28, 2025
8 checks passed
@stuartc stuartc deleted the keep-manual-run-body branch February 28, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Don't clear input panel when user clicks save
2 participants