Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore esbuild to 0.17.13 #2963

Merged
merged 1 commit into from
Feb 24, 2025
Merged

restore esbuild to 0.17.13 #2963

merged 1 commit into from
Feb 24, 2025

Conversation

midigofrank
Copy link
Collaborator

Description

This current esbuild, 0.24.2, fails when --minify is provided:

✘ [ERROR] Could not resolve "path"

    node_modules/@typescript/vfs/dist/vfs.esm.js:575:17:
      575 │   return require(String.fromCharCode(112, 97, 116, 104));
          ╵                  ^

  The package "path" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "--platform=node" to do that, which will remove this error.

1 error
** (Mix) `mix esbuild default --minify` exited with 1 

Validation steps

  1. Run mix setup to install the configured esbuild version
  2. Purge the old static files that were generated by running git clean -fdx priv/static
  3. Run mix assets.deploy. No error should be logged

Additional notes for the reviewer

There is a follow up issue to upgrade esbuild: #2962

AI Usage

Please disclose how you've used AI in this work (it's cool, we just want to know!):

  • Code generation (copilot but not intellisense)
  • Learning or fact checking
  • Strategy / design
  • Optimisation / refactoring
  • Translation / spellchecking / doc gen
  • Other
  • I have not used AI

You can read more details in our Responsible AI Policy

Pre-submission checklist

  • I have performed a self-review of my code.
  • I have implemented and tested all related authorization policies. (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@midigofrank midigofrank self-assigned this Feb 24, 2025
@midigofrank midigofrank requested a review from stuartc February 24, 2025 07:03
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.50%. Comparing base (0bcec90) to head (eb0cf6b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2963      +/-   ##
==========================================
- Coverage   91.53%   91.50%   -0.04%     
==========================================
  Files         344      344              
  Lines       12542    12542              
==========================================
- Hits        11480    11476       -4     
- Misses       1062     1066       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stuartc stuartc merged commit af690f9 into main Feb 24, 2025
7 of 8 checks passed
@stuartc stuartc deleted the restore-esbuild-to-0.17.13 branch February 24, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants