Fix another variant blank log lines #2959
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re: #2914
Been seeing a bunch of warnings on Sentry saying that a log line couldn't be blank/is rejected.
Really thought I fixed this one.
From what it looks like,
console.log(undefined)
arrives as%{"message": []}
which was previously considered blank.This PR converts drops
[]
from the list of 'empty values' when casting, which is valid (from the previous set of changes on this issue).Now the question is here, is there such a thing as a log line that is "too blank"?
So in the node real, an empty console.log, really logs an empty string, and logging
undefined
printsundefined
.Perhaps this should be changed upstream in the worker, either actually send
['undefined']
or skip sending the message?Validation steps
See:
test/integration/web_and_worker_test.exs:290
, and run it withmix test.watch test/integration/web_and_worker_test.exs:290
.This test checks the different output casting for log lines.
Additional notes for the reviewer
AI Usage
Please disclose how you've used AI in this work (it's cool, we just want to know!):
You can read more details in our Responsible AI Policy
Pre-submission checklist
:owner
,:admin
,:editor
,:viewer
)