Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create work orders with {} when input data is not manually set #2952

Open
christad92 opened this issue Feb 19, 2025 · 1 comment · May be fixed by #2982
Open

Create work orders with {} when input data is not manually set #2952

christad92 opened this issue Feb 19, 2025 · 1 comment · May be fixed by #2982
Assignees

Comments

@christad92
Copy link

christad92 commented Feb 19, 2025

In the inspector, when I'm editing my job code, I can't run my job unless I have some input.
Well, okay, fair enough, but I also find myself setting {} to my input all the time. I’d love it if I could just run the job and, if I haven’t specified an input, for {} to be used.

Possible that this touches on #2944 - a bug we've discovered recently.

Note that this is not the big request for manual runs, but rather a short-term, high-value improvement to quality of life.


Here's more information from @taylordowns2000 :

A really big bug-bear for the group (in Ghana) this week was having to type {} in the left side panel to run a job. This was probably the biggest common blocker to the UX.

I’m quite eager to introduce the “better manual runs” stuff (with those diagrams I’ve shared already) diagrams

But in the meantime, I was expecting that this would work:

@@ -123,6 +123,7 @@ defmodule LightningWeb.WorkflowLive.ManualWorkorder do
     <div :if={is_nil(@selected_dataclip)} class="grow">
       <.input
         type="textarea"
         value="{}" # 👈 Look here!
         field={@form[:body]}
         disabled={@disabled}
         class="h-full font-mono proportional-nums text-slate-200 bg-slate-700"

That one line addition sets the default value to {} which I think is great… if you don’t specify an input and just want to run get('https://www.google.com/') we let you type that and then hit run. End of story!

But… it doesn’t actually work. The run button is greyed out. Ayo thinks it may be related to the run button listening to an onchange event in the input panel. If I click into the input after this default value loads, backspace to remove a } and then type the same { back, everything is perfect.

@github-project-automation github-project-automation bot moved this to New Issues in v2 Feb 19, 2025
@theroinaochieng theroinaochieng moved this from New Issues to Tech Backlog in v2 Feb 19, 2025
@theroinaochieng theroinaochieng moved this from Tech Backlog to Ready in v2 Feb 19, 2025
@theroinaochieng theroinaochieng moved this from Ready to In progress in v2 Feb 25, 2025
@theroinaochieng theroinaochieng moved this from In progress to Ready in v2 Feb 25, 2025
@stuartc stuartc moved this from Ready to In progress in v2 Feb 28, 2025
@jyeshe jyeshe linked a pull request Feb 28, 2025 that will close this issue
11 tasks
@jyeshe
Copy link
Member

jyeshe commented Mar 6, 2025

We have a PR that solves it but to make it a solution for any use @stuartc is working on a refactoring that encompasses pre-existing validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants