Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade esbuild #2962

Open
midigofrank opened this issue Feb 24, 2025 · 0 comments
Open

Upgrade esbuild #2962

midigofrank opened this issue Feb 24, 2025 · 0 comments

Comments

@midigofrank
Copy link
Collaborator

Details

Lightning is currently on esbuild 0.17.13. The latest version of esbuild, as of this writing is 0.25.0.
We need to upgrade to the latest version to get all the improvements and fixes that have been added.

At the moment, trying to upgrade to > 0.20 results in the following error when you try to --minify the assets:

✘ [ERROR] Could not resolve "path"

    node_modules/@typescript/vfs/dist/vfs.esm.js:575:17:
      575 │   return require(String.fromCharCode(112, 97, 116, 104));
          ╵                  ^

  The package "path" wasn't found on the file system but is built into node. Are you trying to bundle for node? You can use "--platform=node" to do that, which will remove this error.

1 error
** (Mix) `mix esbuild default --minify` exited with 1
@midigofrank midigofrank moved this to Tech Backlog in v2 Feb 24, 2025
@midigofrank midigofrank added this to v2 Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Tech Backlog
Development

No branches or pull requests

1 participant