Skip to content

Commit

Permalink
support turning off console.log statements (#2927)
Browse files Browse the repository at this point in the history
* support turning off console.log statments

* fix failing tests

* move get_run_options to Runs context

* move up migration date

* update changelog

---------

Co-authored-by: Stuart Corbishley <[email protected]>
  • Loading branch information
midigofrank and stuartc authored Feb 26, 2025
1 parent 86f20c9 commit 8ccf424
Show file tree
Hide file tree
Showing 20 changed files with 323 additions and 59 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ and this project adheres to
[#1832](https://github.com/OpenFn/lightning/issues/1832)
- Allow users to configure their preferred log levels
[#2206](https://github.com/OpenFn/lightning/issues/2206)
- Allow project admins and owners to disable `console.log()` in jobs
[#2205](https://github.com/OpenFn/lightning/issues/2205)

### Changed

Expand Down
105 changes: 77 additions & 28 deletions assets/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion assets/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"zustand": "^4.3.7"
},
"devDependencies": {
"@openfn/ws-worker": "^1.9.1",
"@openfn/ws-worker": "^1.11.1",
"@types/marked": "^4.0.8",
"@types/react": "^18.0.15",
"@types/react-dom": "^18.0.6",
Expand Down
1 change: 1 addition & 0 deletions lib/lightning/policies/project_users.ex
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ defmodule Lightning.Policies.ProjectUsers do
:edit_data_retention,
:add_project_user,
:remove_project_user,
:edit_run_settings,
:create_collection
],
do: project_user.role in [:owner, :admin]
Expand Down
Loading

0 comments on commit 8ccf424

Please sign in to comment.