Fix credo warning

OpenFn · Jan 10, 2025 · 407eec9 · 407eec9
1 parent 59229fb
commit 407eec9
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/lib/lightning_web/controllers/api/workflows_controller.ex b/lib/lightning_web/controllers/api/workflows_controller.ex
@@ -378,6 +378,15 @@ defmodule LightningWeb.API.WorkflowsController do
     )
   end
 
+  defp maybe_handle_error(conn, {:error, :too_many_workflows, %Message{text: error_msg}}, workflow_id) do
+    reply_422(
+      conn,
+      workflow_id,
+      :project_id,
+      error_msg
+    )
+  end
+
   defp maybe_handle_error(conn, {:error, reason}, workflow_id)
        when reason in [:invalid_project_id, :invalid_project_id_format] do
     case reason do
@@ -456,14 +465,6 @@ defmodule LightningWeb.API.WorkflowsController do
           "A workflow can have only one trigger enabled at a time."
         )
 
-      {:error, :too_many_workflows, %Message{text: error_msg}} ->
-        reply_422(
-          conn,
-          workflow_id,
-          :project_id,
-          error_msg
-        )
-
       result ->
         result
     end

diff --git a/test/lightning/projects/provisioner_test.exs b/test/lightning/projects/provisioner_test.exs
@@ -458,7 +458,7 @@ defmodule Lightning.Projects.ProvisionerTest do
       assert flatten_errors(changeset) == %{
                workflows: [
                  %{
-                   triggers: [%{id: ["This email address already exists."]}, %{}]
+                   triggers: [%{id: ["This value should be unique."]}, %{}]
                  }
                ]
              }