Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move REUSE licenses in REUSE.toml #225

Merged
merged 10 commits into from
Nov 22, 2024
Merged

Move REUSE licenses in REUSE.toml #225

merged 10 commits into from
Nov 22, 2024

Conversation

Ludee
Copy link
Member

@Ludee Ludee commented Nov 19, 2024 •
edited
Loading

Summary of the discussion

Remove the .license files and add info to REUSE.toml

Type of change (CHANGELOG.md)

Updated

  • Update REUSE licenses for json (#225)
  • Update example contributors and roles (#225)

Workflow checklist

Automation

Closes #224

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee added type: enhancement ⚙️ Improvement of an existing feature priority: high ⚡ High priority part: backend 🧱 Backend component status: completed ✔️ Task has been completed labels Nov 19, 2024
@Ludee Ludee requested a review from jh-RLI November 19, 2024 20:08
@Ludee Ludee self-assigned this Nov 19, 2024
@Ludee Ludee marked this pull request as ready for review November 19, 2024 22:02
jh-RLI
jh-RLI reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor enhancement to the build_source directory structure.

metadata/v2/v20/build_source/scripts/example_contributors.json Outdated Show resolved Hide resolved
@Ludee Ludee merged commit fca520e into develop Nov 22, 2024
3 checks passed
@Ludee Ludee deleted the feature-224-license branch November 22, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jh-RLI jh-RLI jh-RLI left review comments

Assignees

@Ludee Ludee

Labels
part: backend 🧱 Backend component priority: high ⚡ High priority status: completed ✔️ Task has been completed type: enhancement ⚙️ Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collect license files in licenses directory?
2 participants
@Ludee @jh-RLI