Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update create template #216 #217

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Update create template #216 #217

merged 3 commits into from
Nov 12, 2024

Conversation

Ludee
Copy link
Member

@Ludee Ludee commented Nov 11, 2024 •
edited by jh-RLI
Loading

Summary of the discussion

Include a simple function that sets the boundingBox and metaMetadata in the template.

Type of change (CHANGELOG.md)

Updated

  • Update create template (#217)

Workflow checklist

Automation

Closes #216

PR-Assignee

  • 🐙 Follow the workflow in CONTRIBUTING.md
  • 📝 Update the CHANGELOG.md
  • 📙 Update the documentation
  • 🐙 Assign a reviewer to the PR

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee requested a review from jh-RLI November 11, 2024 20:43
@Ludee Ludee self-assigned this Nov 11, 2024
@Ludee Ludee added type: bug 🐛 Something isn't working type: enhancement ⚙️ Improvement of an existing feature labels Nov 11, 2024
@Ludee Ludee marked this pull request as ready for review November 11, 2024 20:46
jh-RLI
jh-RLI approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice :)

@Ludee Ludee merged commit eaf2680 into develop Nov 12, 2024
2 checks passed
@Ludee Ludee deleted the feature-216-template branch November 12, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jh-RLI jh-RLI jh-RLI approved these changes

Assignees

@Ludee Ludee

Labels
type: bug 🐛 Something isn't working type: enhancement ⚙️ Improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Template script needs improvement
2 participants
@Ludee @jh-RLI