Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify the mandatory fields to the json schema #160

Merged
merged 10 commits into from
Oct 15, 2024
Merged

Conversation

Ludee
Copy link
Member

@Ludee Ludee commented Oct 15, 2024

Summary of the discussion

The Badge System defined some basic mandatory (required) fields corresponding to the Iron Badge.

  • collection name
  • resources - name
  • resources - schema - fields - name (column name)
  • resources - schema - fields - type (column data type)
  • resources - schema - primaryKey
  • resources - schema - foreignKeys - fields
  • resources - schema - foreignKeys - reference - resource
  • resources - schema - foreignKeys - reference - fields

Type of change (CHANGELOG.md)

Added

  • Add mandatory fields to the json schema (Iron Badge) (#160)

Workflow checklist

Automation

Closes #40

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee added part: documentation 📖 Improvements or additions to documentation type: enhancement ⚙️ Improvement of an existing feature labels Oct 15, 2024
@Ludee Ludee self-assigned this Oct 15, 2024
@Ludee Ludee marked this pull request as ready for review October 15, 2024 10:59
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jh-RLI jh-RLI merged commit 5900bab into develop Oct 15, 2024
2 checks passed
@jh-RLI jh-RLI deleted the feature-40-mandatory branch October 15, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: documentation 📖 Improvements or additions to documentation type: enhancement ⚙️ Improvement of an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Json schema does not specify any mandatory fields
2 participants