Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add embargo period to general keys #140 #155

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Conversation

Ludee
Copy link
Member

@Ludee Ludee commented Oct 11, 2024

Summary of the discussion

Add three keys in a section embargoPeriod: start / end / isActive.
Badge is bronze.

Type of change (CHANGELOG.md)

Added

  • Add embargoPeriod section with keys start, end, isActive (#155)

Workflow checklist

Automation

Closes #140

PR-Assignee

Reviewer

  • 🐙 Follow the Reviewer Guidelines
  • 🐙 Provided feedback and show sufficient appreciation for the work done

@Ludee Ludee added type: enhancement ⚙️ Improvement of an existing feature SIROP labels Oct 11, 2024
@Ludee Ludee self-assigned this Oct 11, 2024
@Ludee Ludee marked this pull request as ready for review October 11, 2024 21:21
Copy link
Contributor

@jh-RLI jh-RLI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jh-RLI jh-RLI merged commit 1210ff4 into develop Oct 14, 2024
2 checks passed
@jh-RLI jh-RLI deleted the feature-140-embargo branch October 14, 2024 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement ⚙️ Improvement of an existing feature
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add embargo information to the metadata
2 participants