Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing schema as a Python object #471

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Allow passing schema as a Python object #471

merged 1 commit into from
Dec 18, 2024

Conversation

radix0000
Copy link
Contributor

Allow the calling application to load the schema rather than flatten-tool. Partial work around for: #447

Have created a whole new using as a library section in docs, in order to mention this.

@ghost
Copy link

ghost commented Dec 10, 2024

That's great thanks - my only comment would be is it a good idea to add a small test?

Allow the calling application to load the schema rather than flatten-tool
Partial work around for: #447
@radix0000 radix0000 requested a review from a user December 12, 2024 14:56
@radix0000
Copy link
Contributor Author

Have added some tests.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think I would call it Added rather than Fixed. Fixed implies it was broken before where this is a new feature. But don't have strong views; could change in release PR too.

@radix0000 radix0000 merged commit ec0e00b into main Dec 18, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant